This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Manager is not element #60
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
clero
force-pushed
the
manager_is_not_element
branch
2 times, most recently
from
4c1e963 to
982cdab
Compare
clero
force-pushed
the
manager_is_not_element
branch
from
982cdab to
da31a49
Compare
clero
force-pushed
the
manager_is_not_element
branch
3 times, most recently
from
08c0988 to
8d0cf2c
Compare
clero
force-pushed
the
manager_is_not_element
branch
from
8d0cf2c to
600f0a0
Compare
clero
force-pushed
the
manager_is_not_element
branch
from
600f0a0 to
8f3dae5
Compare
clero
force-pushed
the
manager_is_not_element
branch
from
8f3dae5 to
7c7ea94
Compare
Signed-off-by: Jules Clero <julesx.clero@intel.com>
Some elements are logging but ParameterMgr is able to do the same. This patch lets the ParameterMgr handle logging whenever it's possible. Signed-off-by: Jules Clero <julesx.clero@intel.com>
String lists are often used as containers for function results. To avoid copy paste, this patch introduces the Results type to replace std::list<std::string> when relevant. Documentation has been updated on modified prototype. Signed-off-by: Jules Clero <julesx.clero@intel.com>
This log is meaningless, as we know subsystems we are attempting to load. We log only if there is an error. Signed-off-by: Jules Clero <julesx.clero@intel.com>
Signed-off-by: Jules Clero <julesx.clero@intel.com>
This log information is easy to retrieve by looking the structure file. Signed-off-by: Jules Clero <julesx.clero@intel.com>
The client may choose if he wants to log the error when adding a criterion. Signed-off-by: Jules Clero <julesx.clero@intel.com>
In prevision of logging rework, this patch removes logging from plugins. Signed-off-by: Jules Clero <julesx.clero@intel.com>
uint8_t type seems to be buggy when we try to log it through stream API. This patch uses uint32_t type instead to count criterion modifications. Signed-off-by: Jules Clero <julesx.clero@intel.com>
Logs were provided by Element god class. This patch moves logging in the log library which is used by the ParameterMgr. Logs remains almost identical from before. Context title after context closing bracket has been removed to enhance readability. Change-Id: Ic7dca65c3cc88eb06a1883c4fb01af9809b19e42 Signed-off-by: Jules Clero <julesx.clero@intel.com>
Signed-off-by: Jules Clero <julesx.clero@intel.com>
Plugins are now able to log. An ILogger object is provided to plugins to do that. Signed-off-by: Jules Clero <julesx.clero@intel.com>
Signed-off-by: Jules Clero <julesx.clero@intel.com>
Change-Id: Ib31547b3f899f96b837ac125ea7b0feb8c946760 Signed-off-by: Jules Clero <julesx.clero@intel.com>
Signed-off-by: David Wagner <david.wagner@intel.com>
Contributor
|
Please rebase and resubmit against "next" |
init function is defined in Element god class but is used only for plugins initialization after structure and settings loading. This patch delegate Subsystem initialization to SystemClass which is the direct parent. Signed-off-by: Jules Clero <julesx.clero@intel.com>
The element class really looks like a god class with stuff that has really nothing to do with its role. toString and appendTitle are good example of stuff that should be move away from it. This patch move those two functions into utility where they seems to belong. Signed-off-by: Sébastien Gonzalve <oznog@users.noreply.github.com> Signed-off-by: Jules Clero <julesx.clero@intel.com>
SelectionCriteria class is dependant from Element class because of the checksum calculation algorithm which is based on child name. In preparation of a rework, we exclude it from the structure checksum calculation. Moreover the criterion mechanism is not a part of the parameter-framework structure. Thus, this decision is fair. Signed-off-by: Jules Clero <julesx.clero@intel.com>
ParameterManager does not have to be a part of the Element tree. Indeed, it is not represented in any xml file. This patch avoids this inheritance and removes some "tricks" which was used to forget the ParameterMgr root element. Signed-off-by: Jules Clero <julesx.clero@intel.com>
clero
force-pushed
the
manager_is_not_element
branch
from
7c7ea94 to
ce012c8
Compare
Contributor
Author
|
replaced by #93 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👍
This pull request depends on #58
Please review only 330c679 00a8b8e 4e9e90a 7eafd2e
@makohoek @gdenneul @dawagner @krocard